Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Several large parquet optimizations #18437

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

coastalwhite
Copy link
Collaborator

  • Only verify UTF-8 on a dictionary page once (duh)
  • Don't even worry about the page validity if it is never null
  • Dispatch between pre-filter and post-filter for parallel=prefiltered.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 83.17073% with 69 lines in your changes missing coverage. Please review.

Project coverage is 79.87%. Comparing base (22a97bf) to head (7196ede).
Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
...olars-parquet/src/arrow/read/deserialize/simple.rs 72.04% 26 Missing ⚠️
...et/src/arrow/read/deserialize/fixed_size_binary.rs 50.00% 7 Missing ⚠️
...arquet/src/arrow/read/deserialize/primitive/mod.rs 86.79% 7 Missing ⚠️
crates/polars-io/src/parquet/read/read_impl.rs 91.17% 6 Missing ⚠️
...et/src/arrow/read/deserialize/primitive/integer.rs 81.81% 6 Missing ⚠️
...lars-parquet/src/arrow/read/deserialize/binview.rs 86.84% 5 Missing ⚠️
...lars-parquet/src/arrow/read/deserialize/boolean.rs 75.00% 4 Missing ⚠️
.../polars-parquet/src/arrow/read/deserialize/null.rs 50.00% 3 Missing ⚠️
...s-parquet/src/arrow/read/deserialize/dictionary.rs 80.00% 2 Missing ⚠️
crates/polars-arrow/src/bitmap/bitmap_ops.rs 93.33% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18437      +/-   ##
==========================================
- Coverage   79.91%   79.87%   -0.04%     
==========================================
  Files        1495     1496       +1     
  Lines      200261   200357      +96     
  Branches     2867     2867              
==========================================
+ Hits       160034   160042       +8     
- Misses      39681    39769      +88     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Only verify UTF-8 on a dictionary page once (duh)

😄

@ritchie46 ritchie46 merged commit f6ef516 into pola-rs:main Aug 28, 2024
27 checks passed
@coastalwhite coastalwhite deleted the perf-parquet branch August 28, 2024 17:01
r-brink pushed a commit to r-brink/polars that referenced this pull request Aug 29, 2024
@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants