Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Split Reduction into it plus ReductionState #18460

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 29, 2024

This also fixes issues like mean overflowing, and the empty sum returning null rather than 0.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 201 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (915f164) to head (2a6409f).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/reduce/nan_min_max.rs 0.00% 74 Missing ⚠️
crates/polars-expr/src/reduce/min_max.rs 0.00% 58 Missing ⚠️
crates/polars-stream/src/nodes/reduce.rs 0.00% 23 Missing ⚠️
crates/polars-expr/src/reduce/mean.rs 0.00% 18 Missing ⚠️
crates/polars-expr/src/reduce/sum.rs 0.00% 15 Missing ⚠️
crates/polars-expr/src/reduce/len.rs 0.00% 6 Missing ⚠️
crates/polars-expr/src/reduce/convert.rs 0.00% 4 Missing ⚠️
crates/polars-core/src/scalar/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18460      +/-   ##
==========================================
+ Coverage   79.84%   79.86%   +0.01%     
==========================================
  Files        1497     1498       +1     
  Lines      201828   201805      -23     
  Branches     2867     2867              
==========================================
+ Hits       161141   161163      +22     
+ Misses      40141    40096      -45     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit c263526 into pola-rs:main Aug 30, 2024
21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants