Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix map_elements for List return dtypes #18567

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Sep 5, 2024

Closes #18472

This makes sure we respect the return_dtype if it's a List type, rather than discarding it and relying on auto-inference.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 63.93443% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (6d4b79d) to head (94dd259).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/map/series.rs 57.14% 15 Missing ⚠️
crates/polars-python/src/series/map.rs 66.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18567      +/-   ##
==========================================
+ Coverage   79.80%   79.83%   +0.03%     
==========================================
  Files        1501     1501              
  Lines      201952   201736     -216     
  Branches     2868     2869       +1     
==========================================
- Hits       161163   161063     -100     
+ Misses      40243    40127     -116     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit c85b338 into main Sep 5, 2024
28 checks passed
@ritchie46 ritchie46 deleted the fix-skip-nulls-dtype branch September 5, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map_elements incorrectly converts all output to NULL
2 participants