fix: Scanning hive partitioned files where hive columns are partially included in the file #18626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
changed the title
github-actions
bot
added
fix
ritchie46
reviewed
Sep 9, 2024
crates/polars-io/src/hive.rs
Outdated
| }; | ||
| // Insert these hive columns in the order they are stored in the file. | ||
| for s in hive_columns { | ||
| let i = match df.get_columns().binary_search_by_key( |
There was a problem hiding this comment.
This feels very expensive? Is there a way we can make a hashmap up front to amortize cost?
There was a problem hiding this comment.
Yeah I didn't like this either, I have cooked something up and pushed it in a commit 😄
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18626 +/- ##
=======================================
Coverage 79.91% 79.91%
=======================================
Files 1506 1506
Lines 203047 203086 +39
Branches 2889 2891 +2
=======================================
+ Hits 162271 162306 +35
- Misses 40226 40230 +4
Partials 550 550 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.