Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert automatically turning on Parquet prefiltered #18720

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@coastalwhite coastalwhite changed the title revert: Automatically turn on Parquet prefiltered fix: Automatically turn on Parquet prefiltered Sep 12, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Sep 12, 2024
@coastalwhite coastalwhite changed the title fix: Automatically turn on Parquet prefiltered fix: Revert automatically turning on Parquet prefiltered Sep 12, 2024
@ritchie46
Copy link
Member

Can confirm, all tpch queries run again

@ritchie46 ritchie46 merged commit dddf0b7 into pola-rs:main Sep 12, 2024
21 of 22 checks passed
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (0e5e554) to head (57a3da4).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/parquet/read/read_impl.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18720      +/-   ##
==========================================
- Coverage   79.90%   79.86%   -0.04%     
==========================================
  Files        1513     1513              
  Lines      203465   203466       +1     
  Branches     2892     2892              
==========================================
- Hits       162579   162508      -71     
- Misses      40338    40410      +72     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants