Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix accidental raise on shape 1 #18748

Merged
merged 1 commit into from
Sep 15, 2024
Merged

fix: Fix accidental raise on shape 1 #18748

merged 1 commit into from
Sep 15, 2024

Conversation

ritchie46
Copy link
Member

fixes #18736

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 15, 2024
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.85%. Comparing base (962b576) to head (1f6b9ed).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/frame/mod.rs 0.00% 4 Missing ⚠️
crates/polars-mem-engine/src/executors/stack.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18748      +/-   ##
==========================================
- Coverage   79.86%   79.85%   -0.01%     
==========================================
  Files        1517     1517              
  Lines      205542   205530      -12     
  Branches     2892     2892              
==========================================
- Hits       164156   164134      -22     
- Misses      40838    40848      +10     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 4894e24 into main Sep 15, 2024
26 checks passed
@ritchie46 ritchie46 deleted the shape branch September 15, 2024 08:06
nameexhaustion pushed a commit to nameexhaustion/polars that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add a Series to an empty DataFrame only if the Series lengh is 1
1 participant