Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Fix literal type mapping example in lit docstrings #18756

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Sep 15, 2024

They seem to have been wrong for a long time.

@eitsupi eitsupi changed the title docs(python): fix literal type mapping example in lit() docstrings docs(python): Fix literal type mapping example in lit docstrings Sep 15, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars and removed title needs formatting labels Sep 15, 2024
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (4894e24) to head (708a860).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18756   +/-   ##
=======================================
  Coverage   79.85%   79.85%           
=======================================
  Files        1517     1517           
  Lines      205530   205530           
  Branches     2892     2892           
=======================================
+ Hits       164119   164130   +11     
+ Misses      40863    40852   -11     
  Partials      548      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Indeed. This is wrong since 1.0

@ritchie46 ritchie46 merged commit 9766a25 into pola-rs:main Sep 22, 2024
15 of 16 checks passed
@eitsupi eitsupi deleted the fix-lit-doc branch September 22, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants