fix: Dropped/shifted rows in parquet scan with streaming=True
#18766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
Sep 16, 2024
| .map(|(iter_idx, (_rg_idx, _md, slice, row_count_start))| { | ||
| let md = &file_metadata.row_groups[iter_idx]; | ||
|
|
||
| .map(|(md, slice, row_count_start)| { |
There was a problem hiding this comment.
iter_idx was an index into the previous version of partitioned metadata - I was just meant to restore this to directly use md from par_iter()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18766 +/- ##
==========================================
- Coverage 79.88% 79.85% -0.04%
==========================================
Files 1513 1517 +4
Lines 203466 205530 +2064
Branches 2892 2892
==========================================
+ Hits 162546 164120 +1574
- Misses 40372 40862 +490
Partials 548 548 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
nameexhaustion
force-pushed
the
pq-rg
branch
2 times, most recently
from
e736e08
to
955fd4f
Compare
nameexhaustion
force-pushed
the
pq-rg
branch
from
955fd4f
to
f52cb09
Compare
|
Branch is based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18739
Fixes #18779