Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add panic to unchecked DataFrame constructors in debug mode #18807

Merged
merged 1 commit into from
Sep 18, 2024
Merged

refactor: Add panic to unchecked DataFrame constructors in debug mode #18807

merged 1 commit into from
Sep 18, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Sep 18, 2024 •
edited
Loading

Should help to catch things in tests

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Sep 18, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review September 18, 2024 09:11
@nameexhaustion nameexhaustion marked this pull request as draft September 18, 2024 09:23
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 18, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #18807 will not alter performance

Comparing nameexhaustion:df-new-unchecked (654063e) with main (8114b52)

Summary

✅ 40 untouched benchmarks

@nameexhaustion nameexhaustion marked this pull request as ready for review September 18, 2024 11:57
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@77b1e42). Learn more about missing BASE report.
Report is 26 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #18807   +/-   ##
=======================================
  Coverage        ?   79.86%           
=======================================
  Files           ?     1518           
  Lines           ?   205634           
  Branches        ?     2892           
=======================================
  Hits            ?   164226           
  Misses          ?    40860           
  Partials        ?      548

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 9384945 into pola-rs:main Sep 18, 2024
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 23, 2024
@nameexhaustion nameexhaustion deleted the df-new-unchecked branch September 27, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees

@nameexhaustion nameexhaustion

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nameexhaustion @ritchie46 @c-peters