Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check values in strict cast Int to Time #18854

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #18844.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 68.22430% with 34 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (2b4986a) to head (8eb8511).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...ates/polars-arrow/src/compute/cast/primitive_to.rs 44.64% 31 Missing ⚠️
crates/polars-arrow/src/compute/cast/mod.rs 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18854      +/-   ##
==========================================
+ Coverage   79.86%   79.89%   +0.02%     
==========================================
  Files        1518     1519       +1     
  Lines      205610   205963     +353     
  Branches     2893     2898       +5     
==========================================
+ Hits       164202   164545     +343     
- Misses      40860    40870      +10     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 66960ff into pola-rs:main Sep 23, 2024
26 checks passed
@coastalwhite coastalwhite deleted the fixes/time-cast-oob branch September 23, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Casting negative or large values to Time causes panic
2 participants