Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make with_column_unchecked take Column #18863

Merged

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (2b4986a) to head (8e0034c).
Report is 80 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/parquet/read/read_impl.rs 66.66% 1 Missing ⚠️
crates/polars-io/src/parquet/read/reader.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18863      +/-   ##
==========================================
+ Coverage   79.86%   79.88%   +0.02%     
==========================================
  Files        1518     1519       +1     
  Lines      205610   205873     +263     
  Branches     2893     2898       +5     
==========================================
+ Hits       164202   164470     +268     
+ Misses      40860    40855       -5     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b68e259 into pola-rs:main Sep 23, 2024
21 checks passed
@coastalwhite coastalwhite deleted the refactor/with-column-unchecked-scalar branch September 23, 2024 16:06
@c-peters c-peters added the accepted Ready for implementation label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants