Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Improve rename performace for Lazy API #18890

Merged
merged 2 commits into from
Sep 24, 2024
Merged

perf: Improve rename performace for Lazy API #18890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8128ce8
Initial fix for rename perf issue
siddharth-vi Sep 24, 2024
314929a
Fix clippy linting issue
siddharth-vi Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions crates/polars-plan/src/plans/functions/rename.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,18 @@ pub(super) fn rename_impl(
existing: &[PlSmallStr],
new: &[PlSmallStr],
) -> PolarsResult<DataFrame> {
let positions = existing
.iter()
.map(|old| df.get_column_index(old))
.collect::<Vec<_>>();
let positions = if existing.len() > 1 && df.get_columns().len() > 10 {
let schema = df.schema();
existing
.iter()
.map(|old| schema.get_full(old).map(|(idx, _, _)| idx))
.collect::<Vec<_>>()
} else {
existing
.iter()
.map(|old| df.get_column_index(old))
.collect::<Vec<_>>()
};

for (pos, name) in positions.iter().zip(new.iter()) {
// the column might be removed due to projection pushdown
Expand Down
Loading