Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Out-of-bounds gather in categorical->int cast #18897

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 24, 2024

Fixes #18894.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 24, 2024
@ritchie46 ritchie46 merged commit afff7a4 into pola-rs:main Sep 24, 2024
19 of 20 checks passed
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (d3f8a5c) to head (5323061).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...-core/src/chunked_array/logical/categorical/mod.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18897      +/-   ##
==========================================
- Coverage   79.89%   79.88%   -0.01%     
==========================================
  Files        1520     1520              
  Lines      206552   206552              
  Branches     2906     2906              
==========================================
- Hits       165020   165007      -13     
- Misses      40984    40997      +13     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorical cast causes out-of-bounds gather access with string cache turned on
2 participants