Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix/skip variety of new-streaming tests, cont #18928

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 25, 2024

No description provided.

@orlp orlp changed the title refactor: Fix/skip variety of new-streaming tests, cont. refactor: Fix/skip variety of new-streaming tests, cont Sep 25, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (2467b27) to head (a2def99).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/reduce/min_max.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18928      +/-   ##
==========================================
- Coverage   79.88%   79.86%   -0.02%     
==========================================
  Files        1521     1521              
  Lines      206850   206858       +8     
  Branches     2906     2906              
==========================================
- Hits       165243   165211      -32     
- Misses      41059    41099      +40     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 68b6f0e into pola-rs:main Sep 26, 2024
26 of 28 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants