refactor: Divide ChunkCompare into Eq and Ineq variants
#18963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divide the `ChunkCompare` trait into two traits `ChunkCompareEq` and
`ChunkCompareIneq`, which allows us to statistically verify that there are no
calls to the inequality methods when these are not available (e.g. for `List`,
`Array` and `Struct`). This makes error handling a lot better as well.
For example, the following was a panic exception before.
```python
import polars as pl
a = pl.Series('a', [[1]], pl.Array(pl.Int8, 1))
b = pl.Series('b', [[1]], pl.Array(pl.Int8, 1))
c = a < b
```
Now, it returns:
```
polars.exceptions.InvalidOperationError: cannot perform '<' comparison between series 'a' of dtype: array[i8, 1] and series 'b' of dtype: array[i8, 1]
```
Fixes pola-rs#18938.
coastalwhite
requested review from
ritchie46,
orlp and
c-peters
as code owners
github-actions
bot
added
internal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18963 +/- ##
==========================================
+ Coverage 79.83% 79.85% +0.01%
==========================================
Files 1523 1523
Lines 207296 207277 -19
Branches 2906 2906
==========================================
+ Hits 165498 165514 +16
+ Misses 41250 41215 -35
Partials 548 548 ☔ View full report in Codecov by Sentry. |
|
Can you fix the link. Then it's good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divide the
ChunkComparetrait into two traitsChunkCompareEqandChunkCompareIneq, which allows us to statistically verify that there are no calls to the inequality methods when these are not available (e.g. forList,ArrayandStruct). This makes error handling a lot better as well.For example, the following was a panic exception before.
Now, it returns:
Fixes #18938.