feat: Use FFI to extract Series from different Polars binaries #18964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
ritchie46
commented
Sep 27, 2024
| // Eventually we must use Polars' Series Export as that can deal with | ||
| // multiple chunks | ||
| Err(_) => { | ||
| use polars::export::arrow::ffi; |
There was a problem hiding this comment.
Works for now. Ideally I want to use our SeriesExport here later.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18964 +/- ##
==========================================
- Coverage 79.85% 79.83% -0.02%
==========================================
Files 1523 1523
Lines 207292 207315 +23
Branches 2906 2906
==========================================
- Hits 165534 165518 -16
- Misses 41210 41249 +39
Partials 548 548 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.