Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add FixedSizeList equality broadcasting #18967

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #18939.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 90.75630% with 11 lines in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (79fcd53) to head (3aa09af).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...es/polars-core/src/chunked_array/comparison/mod.rs 83.78% 6 Missing ⚠️
crates/polars-compute/src/comparisons/array.rs 95.06% 4 Missing ⚠️
crates/polars-compute/src/comparisons/list.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18967      +/-   ##
==========================================
+ Coverage   79.84%   79.88%   +0.03%     
==========================================
  Files        1523     1523              
  Lines      207302   207394      +92     
  Branches     2904     2904              
==========================================
+ Hits       165529   165683     +154     
+ Misses      41226    41164      -62     
  Partials      547      547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

A rebase away...

@ritchie46 ritchie46 merged commit 6bf93c4 into pola-rs:main Sep 27, 2024
18 checks passed
@coastalwhite coastalwhite deleted the refactor/fsl-broadcasting branch September 27, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when there is a shape mismatch in Arrays
2 participants