Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Mention allow_missing_columns in error message when column not found (parquet) #18972

Merged
merged 3 commits into from
Sep 27, 2024
Merged

refactor: Mention allow_missing_columns in error message when column not found (parquet) #18972

merged 3 commits into from
Sep 27, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Sep 27, 2024 •
edited
Loading

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Sep 27, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review September 27, 2024 12:11
@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 60.07%. Comparing base (13e9717) to head (19cf554).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/parquet/read/reader.rs 75.92% 13 Missing ⚠️
...-stream/src/nodes/parquet_source/metadata_utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main   #18972       +/-   ##
===========================================
- Coverage   79.84%   60.07%   -19.78%     
===========================================
  Files        1523     1523               
  Lines      207409   207529      +120     
  Branches     2904     2904               
===========================================
- Hits       165616   124675    -40941     
- Misses      41246    82307    +41061     
  Partials      547      547

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 6abc2f1 into pola-rs:main Sep 27, 2024
25 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees

@nameexhaustion nameexhaustion

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nameexhaustion @ritchie46 @c-peters