Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix struct literals #19214

Merged
merged 1 commit into from
Oct 13, 2024
Merged

fix: Fix struct literals #19214

merged 1 commit into from
Oct 13, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Oct 13, 2024

Also make AnyValue -> Literal infallible.

fixes #19204

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.68%. Comparing base (207ddb0) to head (7077936).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/lit.rs 74.07% 7 Missing ⚠️
...ars-plan/src/plans/conversion/type_coercion/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19214   +/-   ##
=======================================
  Coverage   79.67%   79.68%           
=======================================
  Files        1532     1532           
  Lines      209190   209185    -5     
  Branches     2415     2415           
=======================================
+ Hits       166677   166690   +13     
+ Misses      41967    41949   -18     
  Partials      546      546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1997293 into main Oct 13, 2024
27 checks passed
@ritchie46 ritchie46 deleted the lit branch October 13, 2024 11:57
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Oct 13, 2024

Also make AnyValue -> Literal infallible.

PopeLiteralValue1 :)

Footnotes

  1. https://en.wikipedia.org/wiki/Papal_infallibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pl.lit({}) PanicException
2 participants