Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make get_list_builder infallible #19217

Merged
merged 1 commit into from
Oct 13, 2024
Merged

chore: Make get_list_builder infallible #19217

merged 1 commit into from
Oct 13, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 13, 2024
@ritchie46 ritchie46 merged commit ff10b38 into main Oct 13, 2024
19 checks passed
@ritchie46 ritchie46 deleted the list branch October 13, 2024 15:02
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (cca31b3) to head (e8e17a6).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../polars-core/src/chunked_array/builder/list/mod.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19217      +/-   ##
==========================================
- Coverage   79.68%   79.67%   -0.01%     
==========================================
  Files        1532     1532              
  Lines      209198   209200       +2     
  Branches     2417     2417              
==========================================
- Hits       166697   166680      -17     
- Misses      41953    41972      +19     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants