fix: Use all chunks in Series from arrow struct
#19218
Merged
+63
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19218 +/- ##
=======================================
Coverage 79.67% 79.67%
=======================================
Files 1532 1532
Lines 209200 209211 +11
Branches 2417 2416 -1
=======================================
+ Hits 166687 166698 +11
Misses 41965 41965
Partials 548 548 ☔ View full report in Codecov by Sentry. |
ritchie46
commented
Oct 14, 2024
| } | ||
| ) | ||
| assert pl.concat([df[0], df[1], df[2]]).select( | ||
| pl.col("nested").list.to_struct() |
There was a problem hiding this comment.
@orlp this expression's dtype is dependent on the data and therefore not suitable for streaming. I want to add a flag for those expressions so that they will fallback to in-memory.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19208