test: Add more tests for list arithmetic #19225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
nameexhaustion
force-pushed
the
list-arith-tests
branch
from
1f49df7
to
a3216e9
Compare
nameexhaustion
commented
Oct 14, 2024
|
|
||
| @pytest.mark.parametrize("broadcast", [True, False]) | ||
| @pytest.mark.parametrize("dtype", [pl.Int64(), pl.Float64()]) | ||
| def test_list_arithmetic_div_ops_zero_denominator( |
There was a problem hiding this comment.
Tests below here were written from before I came up with the parametrization approach
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19225 +/- ##
==========================================
- Coverage 80.00% 79.99% -0.01%
==========================================
Files 1527 1527
Lines 209203 209203
Branches 2415 2415
==========================================
- Hits 167369 167360 -9
- Misses 41286 41295 +9
Partials 548 548 ☔ View full report in Codecov by Sentry. |
ritchie46
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check in some more tests to be extra sure of correctness
test_arithmetic.py -> test_list_arithmetic.py