Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(python): Refactor show_graph #5059

Merged
merged 2 commits into from
Oct 1, 2022
Merged

refactor(python): Refactor show_graph #5059

merged 2 commits into from
Oct 1, 2022

Conversation

zundertj
Copy link
Collaborator

@zundertj zundertj commented Oct 1, 2022

  • Separate graph generation from display, so we can display the right error on missing imports.
  • Avoid temporary file, we can just use the bytes in-memory as we need that anyways to display. Writing is now also in a single place

Closes #5042.

@zundertj
Refactor show_graph
b6370b9 
Separate graph generation from display, so we can display the right error on missing imports.

Closes pola-rs#5042.
@zundertj zundertj mentioned this pull request Oct 1, 2022
Closed
2 tasks
@ritchie46
Copy link
Member

Avoid temporary file, we can just use the bytes in-memory as we need that anyways to display. Writing is now also in a single place

That's nice!

@ritchie46 ritchie46 changed the title Refactor show_graph refactor(python): show_graph Oct 1, 2022
@ritchie46 ritchie46 merged commit 25fef75 into pola-rs:master Oct 1, 2022
@github-actions github-actions bot added python Related to Python Polars refactor Code improvements that do not change functionality labels Oct 1, 2022
@stinodego stinodego changed the title refactor(python): show_graph refactor(python): Refactor show_graph Oct 1, 2022
zundertj added a commit to zundertj/polars that referenced this pull request Jan 7, 2023
@zundertj
refactor(python): show_graph (pola-rs#5059)
1771ecf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python Related to Python Polars refactor Code improvements that do not change functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing column results in .show_graph giving Graphviz import error
2 participants
@zundertj @ritchie46