Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Remove unnecessary brackets in doc examples #6332

Merged
merged 2 commits into from
Jan 28, 2023

Conversation

zundertj
Copy link
Collaborator

Sometimes the brackets add readability as it allows you to lay out more vertically, but in most cases it adds a lot of clutter in my opinion. Feel free to disagree on individual cases.

@zundertj zundertj marked this pull request as draft January 20, 2023 07:17
@stinodego
Copy link
Member

This needs a rebase, but definitely in favor of this change 👍

@zundertj zundertj marked this pull request as ready for review January 28, 2023 09:20
@zundertj
Copy link
Collaborator Author

Yes, done that, was waiting for other changes to go in first.

@zundertj zundertj changed the title Remove unnecessary brackets in doc examples docs(python): Remove unnecessary brackets in doc examples Jan 28, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Jan 28, 2023
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sparks joy 😄

@stinodego stinodego merged commit 3eb1f5e into pola-rs:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants