feat(rust, python): allow expressions as arguments in str.ends_with
#6361
Conversation
polars/polars-lazy/src/tests/tpch.rs
Outdated
| @@ -56,8 +56,7 @@ fn test_q2() -> PolarsResult<()> { | |||
| .inner_join(nation(), "s_nationkey", "n_nationkey") | |||
| .inner_join(region(), "n_regionkey", "r_regionkey") | |||
| .filter(col("p_size").eq(15)) | |||
| .filter(col("p_type").str().ends_with("BRASS")); | |||
|
|
|||
| .filter(col("p_type").str().ends_with("BRASS".into())); | |||
There was a problem hiding this comment.
This should be lit("BRASS".into::<String>())
There was a problem hiding this comment.
Thanks,
This test does not run locally, do you know why ? make test is not enough ?
There was a problem hiding this comment.
It is in the integration tests. Can you run those?
There was a problem hiding this comment.
Ok, it is because I was running testing only in polars/py-polars, and I should run them in polars/polars right ?
There was a problem hiding this comment.
I didn't make .into::<String>()) to work, but I think it works with .to_string()
|
By the way, when I ran the integration test, I got 153 failed run. My problem looks really similar to this one #3121 ( even if I am on Ubuntu). Is there a way to solve this ? |
gab23r
changed the title
str.ends_with
github-actions
bot
added
enhancement
Did you take a look at our CI? That shows all setup steps. |
|
Thanks @gab23r! |
Same as
startswith