Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): add datetime/duration dtype selector groups covering the different timeunits #6425

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jan 25, 2023

ref: #6422, #5300

Extends the available selector groups added in #6295, with DATETIME_DTYPES and DURATION_DTYPES; these each cover the ms, us, and ns time units so you can more ergonomically select any datetime/duration col without having to specify them explicitly (note: ideally we still need a wildcard for timezones - "to be continued...")

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jan 25, 2023
@ritchie46
Copy link
Member

I think this is valuable. 👍

As we are getting more default globals, could we look into adding a test that keeps checking our import times?

@ritchie46 ritchie46 merged commit f0012bf into pola-rs:master Jan 25, 2023
@alexander-beedie
Copy link
Collaborator Author

alexander-beedie commented Jan 25, 2023

As we are getting more default globals, could we look into adding a test that keeps checking our import times?

We should probably go all the way and start a benchmarking/timing suite (that would include import time) that covers all of the basics (eg: do some large aggregations, joins, unions, iteration, etc) and grow it over time 🤔

Could be something that we run before each release to catch performance regressions.

If there aren't plans for this yet I can take a quick survey over other projects to see how they do the same (V8 probably being the most famous example ;)

@alexander-beedie alexander-beedie deleted the datetime-dtypes-selector branch January 25, 2023 09:18
@ritchie46
Copy link
Member

We already run a benchmark on every PR. That compiles python polars in release mode, so we can extend the benchmarks that run afterwards.

@ritchie46
Copy link
Member

If there aren't plans for this yet I can take a quick survey over other projects to see how they do the same (V8 probably being the most famous example ;)

Very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants