Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(python): Fix test issue with tmp directory #6508

Merged
merged 2 commits into from
Jan 27, 2023
Merged

test(python): Fix test issue with tmp directory #6508

merged 2 commits into from
Jan 27, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jan 27, 2023 •
edited
Loading

Fixes #6499

Changes:

  • Use TemporaryDirectory for a few tests that were still writing to disk
  • Add the Path type hint for sink methods.

@github-actions github-actions bot added python Related to Python Polars test Related to the test suite labels Jan 27, 2023
@stinodego stinodego force-pushed the fix-io-test branch 4 times, most recently from 9b0110e to 4aed449 Compare January 27, 2023 19:30
@stinodego stinodego marked this pull request as ready for review January 27, 2023 19:30
@stinodego stinodego force-pushed the fix-io-test branch 2 times, most recently from 807f89a to b538608 Compare January 27, 2023 20:20
@stinodego stinodego merged commit ebb23cc into pola-rs:master Jan 27, 2023
@stinodego stinodego deleted the fix-io-test branch February 22, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python Related to Python Polars test Related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious pytest failure
1 participant
@stinodego