Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Use assert_series_equal instead of s.series_equal(...) #6582

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

stinodego
Copy link
Member

Relates to #6364

assert_series_equal is a more robust tool intended for for testing, so we should use this instead of series_equal.

No new bugs found, so that's good 😄

@github-actions github-actions bot added python Related to Python Polars test Related to the test suite labels Jan 30, 2023
@stinodego
Copy link
Member Author

I'll just merge this as it has no serious implications and is blocking my next improvement.

@stinodego stinodego merged commit 628311e into pola-rs:master Jan 31, 2023
Vincenthays pushed a commit to Vincenthays/polars that referenced this pull request Feb 9, 2023
@stinodego stinodego deleted the assert-series-equal branch February 22, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars test Related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant