test(python): Split long test modules (namespaces) #6668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
stinodego
changed the title
stinodego
force-pushed
the
split-long-test-modules
branch
from
18777a5
to
201a0db
Compare
Vincenthays
pushed a commit
to Vincenthays/polars
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #6364
We really need to create some more structure in the tests folder. There are several modules that are thousands of lines long, and then there are a LOT of smaller test modules. It's not clear where contributors should place their tests.
It's not that easy to come up with a good structure, as concepts overlap. But one thing that's an easy improvement is to move all tests for namespace methods to a namespaces folder:
test_string,test_list, etc. That will clean up some of the longest test modules.Changes:
py-polars/tests/unit/namespacesfolder where namespace methods will be tested.strnamespace and moved it to thenamespacesfolder.test_strptimeas there are a lot of tests related to that.