Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): typo in mean unit test - changed median -> mean #6960

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix(python): typo in mean unit test - changed median -> mean #6960

merged 1 commit into from
Feb 17, 2023

Conversation

MatveyF
Copy link
Contributor

@MatveyF MatveyF commented Feb 17, 2023

test_mean was supposed to test mean() function not median(), resolved the typo.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Feb 17, 2023
@ritchie46 ritchie46 merged commit 7519a29 into pola-rs:master Feb 17, 2023
@stinodego
Copy link
Member

Thanks! Ideally, we'd also update the test inputs to make it fail on median but pass on mean. But that can be done in another PR.

@MatveyF
Copy link
Contributor Author

MatveyF commented Feb 17, 2023

@stinodego that's a great idea, I may do that later.

@MatveyF MatveyF deleted the fix(python)/typo-in-datetime-unit-test branch February 17, 2023 10:54
@MatveyF MatveyF mentioned this pull request Feb 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatveyF @stinodego @ritchie46