fix(python): ensure every type is properly normalised (for groupby_dynamic and groupby_rolling)
#7238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
changed the title
period type is properly normalised (for groupby_dynamic and groupby_rolling)every type is properly normalised (for groupby_dynamic and groupby_rolling)
… LazyFrame, ensure "every" type is properly normalised
alexander-beedie
force-pushed
the
timedelta-offset-fix
branch
from
74c6b80
to
2bc442b
Compare
ritchie46
reviewed
Feb 28, 2023
alexander-beedie
force-pushed
the
timedelta-offset-fix
branch
from
f1f5a09
to
9f052c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(As raised/spotted in the python-polars Discord).
When calling into either of these group functions directly from LazyFrame, the
everyparam was not normalised to string-form ifoffsetandperiodwere None, meaningtimedeltainputs would cause the following exception:Fixed, and added some test coverage.