Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): don't run tests that write to disk by default #7321

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added python Related to Python Polars test Related to the test suite labels Mar 3, 2023
@stinodego
Copy link
Member

Just wondering: are these tests causing issues somehow? Or are they just slow?

@ritchie46
Copy link
Member Author

Just wondering: are these tests causing issues somehow? Or are they just slow?

Just slower.

@ritchie46 ritchie46 merged commit 07c7785 into master Mar 3, 2023
@ritchie46 ritchie46 deleted the writing_tests branch March 3, 2023 10:30
@stinodego
Copy link
Member

We can just use the @pytest.mark.slow then, right? We already have that marker. Keep things simple.

I can send a PR to update accordingly if you want.

@ritchie46
Copy link
Member Author

Ok, I thought it was more separated, but I have no strong opinion on this. Other than that I don't want to trash my disk on every tests call. :)

@stinodego
Copy link
Member

The separation is nice, but pytest markers are a bit annoying to work with... so I'm trying to keep those manageable.

Will probably open a PR for this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars test Related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants