feat(python): Support Numpy ufunc with more than one expression #7924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the pl.reduce trick basically, where the limitation is that non-expressions have to be passed in as kwargs. That is probably the safest anyway. Related issues: pola-rs#6770 : brought up no support for multiple expression, have added a ValueError in response pola-rs#5713 : reminder that there is the `pl.reduce` trick
zundertj
force-pushed
the
np_ufunc_multi_expression
branch
from
d46d45a
to
4366676
Compare
zundertj
changed the title
github-actions
bot
added
enhancement
2 tasks
|
Nice! Thanks @zundertj |
chitralverma
pushed a commit
to chitralverma/polars
that referenced
this pull request
Apr 4, 2023
alicja-januszkiewicz
pushed a commit
to alicja-januszkiewicz/polars
that referenced
this pull request
Apr 17, 2023
chitralverma
pushed a commit
to chitralverma/polars
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the pl.reduce trick basically, where the limitation is that non-expressions have to be passed in as kwargs. That is probably the safest anyway.
Related issues:
#6770 : brought up no support for multiple expression, have added a ValueError in response in #6821.
#5713 : reminder that there is the
pl.reducetrick