Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vignette section on scanning partitions #458

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

etiennebacher
Copy link
Collaborator

Related to #404 (comment)

Thanks for the info @grantmcdermott

@etiennebacher etiennebacher merged commit bd90c93 into main Nov 2, 2023
16 checks passed
@etiennebacher etiennebacher deleted the update-vignette-partition branch November 2, 2023 17:39
@@ -480,8 +477,7 @@ write_dataset(airquality, "airquality-ds", partitioning = "Month")
# Use pattern globbing to scan all parquet files in the folder
aq2 = pl$scan_parquet("airquality-ds/*/*.parquet")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aq2 = pl$scan_parquet("airquality-ds/*/*.parquet")
aq2 = pl$scan_parquet("airquality-ds/**/*.parquet")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah too late 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants