Use the new Runner trait from pallet-evm #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The native runner still has some issues. So let's keep using the stack runner for this PR and do the final switch in a separate PR. Otherwise this PR will be really big and standing for a long time. |
sorpaas
changed the title
ermalkaleci
reviewed
Oct 24, 2020
| ExitReason::Revert(e) => { | ||
| Err(Error { | ||
| code: ErrorCode::InternalError, | ||
| message: format!("evm revert: {:?}", e), |
There was a problem hiding this comment.
returned data need to be converted into readable error message
There was a problem hiding this comment.
Sorry let me fix this in a separate PR!
Fix them in a follow-up PR.
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
* Switch to native runner * Update substrate pin * Fix new version compile * Add back logs and gas used implementations and bump versions * Fix compile and feature updates * Update CI nightly version * Use include_str for bytecode string * Keep using stack runner for now * Fix test specs * Fix extraData mismatch in ts-tests * Skip no gas_limit test Fix them in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from the stack runner to native runner. rel paritytech/substrate#7260
Right now for big contracts, only native runner is usable, due to a state overlay memory leak (#155). In normal operations, due to lack of state overlay and reversion logic being handled outside of runtime, native runner should be generally faster.
The only drawback of native runner is that it's much harder to get exactly gas usage match with Ethereum blockchain.