Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for correct transactionRoot #181

Closed
wants to merge 4 commits into from
Closed

Add test for correct transactionRoot #181

wants to merge 4 commits into from

Conversation

tgmichel
Copy link
Contributor

@tgmichel tgmichel commented Oct 30, 2020 •
edited
Loading

Rel #180

  • Checks an empty transaction list matches Keccka256(56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421).
  • Move calculated sha3Uncles hash to its own step.

This PR is expected to fail until transactions_root is correctly calculated.

@sorpaas
Copy link
Member

sorpaas commented Nov 5, 2020

Going to combine this and #191 for ease of merging.

@tgmichel
Copy link
Contributor Author

tgmichel commented Nov 5, 2020

Great, did you run the tests? I was pulling from sp-transaction-root to check if they are ok.

@tgmichel
Copy link
Contributor Author

tgmichel commented Nov 6, 2020

Closing, fixed in #191

@tgmichel tgmichel closed this Nov 6, 2020
@tgmichel tgmichel deleted the tgmichel-tests branch April 1, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgmichel @sorpaas