Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement block_by_number Runtime API #28

Merged
merged 6 commits into from
Jun 9, 2020
Merged

Implement block_by_number Runtime API #28

merged 6 commits into from
Jun 9, 2020

Conversation

tgmichel
Copy link
Contributor

@tgmichel tgmichel commented Jun 5, 2020

rel #7

@tgmichel
Copy link
Contributor Author

tgmichel commented Jun 5, 2020 •
edited
Loading

This PR includes and empty transactions field as part of the RichBlock response.

This is because the ethereum::Block used as the source for conversion holds a Vec<ethereum::transaction::Transaction> type, while the Rich<Block> expects Vec<frontier_rpc_core::types::transaction::Transaction>.

As a result, compiler would fail with:
expected struct frontier_rpc_core::types::transaction::Transaction, found struct ethereum::transaction::Transaction

sorpaas
sorpaas reviewed Jun 8, 2020
View reviewed changes
frame/ethereum/src/lib.rs Outdated Show resolved Hide resolved
template/runtime/src/lib.rs Show resolved Hide resolved
template/runtime/Cargo.toml Outdated Show resolved Hide resolved
@sorpaas sorpaas merged commit 8319c9a into polkadot-evm:master Jun 9, 2020
@tgmichel tgmichel deleted the tgmichel-block-by-number branch October 7, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorpaas sorpaas sorpaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgmichel @sorpaas