-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pallet-base-fee
storage utility functions
#585
pallet-base-fee
storage utility functions
#585
Conversation
@@ -239,6 +242,21 @@ pub mod pallet { | |||
} | |||
} | |||
|
|||
impl<T: Config> Pallet<T> { | |||
pub fn set_base_fee_per_gas_inner(value: U256) -> Weight { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the reason for doing this, it doesn't seem necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are just some convenience functions to set the storage i.e. to update the storage values on runtime upgrade from outside the pallet or write integration tests.
@@ -239,6 +242,21 @@ pub mod pallet { | |||
} | |||
} | |||
|
|||
impl<T: Config> Pallet<T> { | |||
pub fn set_base_fee_per_gas_inner(value: U256) -> Weight { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename the name to without inner
? I believe this won't conflict with Call
as they are stored in a separate enum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I also believed that was the case and previously tried, but the compiler throws duplicate definitions
error.
* `pallet-base-fee` storage utility functions * fmt
No description provided.