Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fc-rpc #593

Merged
merged 4 commits into from
Mar 3, 2022
Merged

Improve fc-rpc #593

merged 4 commits into from
Mar 3, 2022

Conversation

koushiro
Copy link
Collaborator

@koushiro koushiro commented Feb 23, 2022 •
edited
Loading

  • Split net api and web3 api into their own modules, like fc-rpc-core does
  • Use sp_core::hashing::keccak_256 instead of sha3::Keccak256
  • Remove some useless trait bounds
  • Reorder some imports

@koushiro
Split net api and web3 api into their own modules
0a9552e 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
some nits
fa0eb37 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro koushiro changed the title Split net api and web3 api into their own modules Improve fc-rpc Feb 23, 2022
@koushiro
Copy link
Collaborator Author

@sorpaas PTAL

@koushiro koushiro mentioned this pull request Feb 27, 2022
Merged
@koushiro
Copy link
Collaborator Author

koushiro commented Mar 2, 2022

@sorpaas Could you take a look at this PR?
Is this modification likely to be accepted, if not, I'll just maintain my own fork.

@sorpaas sorpaas merged commit d42806d into polkadot-evm:master Mar 3, 2022
@koushiro koushiro deleted the improve-rpc branch March 3, 2022 06:20
@boundless-forest boundless-forest mentioned this pull request May 11, 2022
Closed
18 tasks
@boundless-forest boundless-forest mentioned this pull request Jul 5, 2022
Closed
32 tasks
abhijeetbhagat pushed a commit to web3labs/frontier that referenced this pull request Jan 11, 2023
@koushiro
Improve fc-rpc (polkadot-evm#593)
f1850f7 
* Split net api and web3 api into their own modules

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* some nits

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* remove some useless trait bound

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorpaas sorpaas sorpaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koushiro @sorpaas