No need to deposit event each block

[boundless-forest]

It is not a good idea to deposit this event so frequently(each block).

[sorpaas]

Seems reasonable. The base fee can be fetched easily through the access function.

[crystalin]

If this can wait for @tgmichel or @nanocryk to agree.
We have ~200 events per block, I don't think this one is adding much to the total.
We can maybe only emit it when it changes, would that work for you @AsceticBear ?

[boundless-forest]

@tgmichel @nanocryk What is your opinion?

[AurevoirXavier]

// IIRC, using `try_mutate` will avoid unnecessary writing OP.
<BaseFeePerGas<T>>::try_mutate(|bf| {
	let new_bf = ...;

	if bf != new_bf {
		*bf = new_bf;
		deposit_event(new_bf);

		Ok(())
	} else {
		Err(())
	}
});

[boundless-forest]

We can maybe only emit it when it changes, would that work for you

In the current implementation of the base fee pallet, the fee update almost every block, the usage blow or above the target fullness. That means only emit when it changes similar to emit each block. This way only works when many consecutive empty blocks, the fee decrease to the minimal value, then no adjustment happened, no more event. @crystalin

if usage > target {
    // increase
} else {
    // decreate
}

when many consecutive empty blocks, the fee decrease to the minimal value

See:

1. Abnormal Base Fee darwinia-network/darwinia-2.0#62
2. https://github.com/paritytech/frontier/blob/master/frame/base-fee/src/lib.rs#L405-L418

Maybe we should introduce a FixedMinFee to the minimum value of a fee.

[tgmichel]

I agree with Wei, I see no harm in just removing the event.