Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix benchmarking #605

Merged
merged 3 commits into from
Mar 17, 2022
Merged

fix benchmarking #605

merged 3 commits into from
Mar 17, 2022

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Mar 16, 2022

Current compiling cargo build --features runtime-benchmarks leads to a compilation error.
This PR:

  • fixes the benchmarking
  • rename the benchmark file to substrate-idiomatic benchmarking.rs
  • Fixes deperecation warnings

@nbaztec nbaztec requested a review from sorpaas as a code owner March 16, 2022 21:18
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Mar 16, 2022

User @nbaztec, please sign the CLA here.

@sorpaas
Copy link
Member

sorpaas commented Mar 17, 2022

Have you updated the lock file? The integration tests do not compile.

@nbaztec
Copy link
Contributor Author

nbaztec commented Mar 17, 2022

Thanks, figured the unused variable was behind a feature flag manual-seal so reverted that change.
Tests work now. 👍

@sorpaas sorpaas merged commit 5fa355f into polkadot-evm:master Mar 17, 2022
@nbaztec nbaztec deleted the fix-benchmarking branch March 18, 2022 13:18
abhijeetbhagat pushed a commit to web3labs/frontier that referenced this pull request Jan 11, 2023
* fix benchmarking

* remove old file

* rename variable back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants