Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gas limit from upload wasm contracts UI #2664

Closed
wants to merge 1 commit into from
Closed

Remove gas limit from upload wasm contracts UI #2664

wants to merge 1 commit into from

Conversation

ps1dr3x
Copy link

@ps1dr3x ps1dr3x commented Apr 30, 2020

This should close #2606 and solve the error that currently prevents the upload of wasm contracts.

It probably needs a review as I'm not familiar with the code base.

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks an absolute million for this.

It is absolutely correct in what it does to support anything after alpha.6, but that is also where we have an issue - chains like Edgeware (contracts) still have the older versions. and it is out there in the wild.

In the past we just broke contracts compat and expected people to upgrade, in this case we (sadly) need logic for both cases. Which, well, just complicated matters.

So I'm strongly in favor of just merging and not having the complication of older support (which we need to clean up at some point), however atm we also don't have an alpha.7 yet. I will have to sleep on it, not really in favor of older support (we have enough of that in a number of places which just makes things harder than it should be), but don't think we can get away without it in this case.

TL;DR It is perfect for current master, but also needs to cater for older. (Which would mean detection of the chain based on the number of args in the actual call and tweaking the tx/UI based on that)

@jacogr jacogr closed this in #2665 May 1, 2020
@ps1dr3x ps1dr3x deleted the remove-gas-limit-from-upload-wasm branch May 1, 2020 08:37
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove gas limit from upload wasm contracts UI
3 participants