Extend u8aToBuffer check with hasBuffer (#1871)

* Extend u8aToBuffer check with hasBuffer * CHANGELOG * Always return Uint8Array * New instance of fallback
polkadot-js · Aug 23, 2023 · f4e0e21 · f4e0e21
1 parent aac9020
commit f4e0e21
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 Changes:
 
 - Fix `u8aTo{BigInt, Bn, Number}` for non-negative `i{8, 16, 32...}` inputs
+- Extend `u8aToBuffer` with `hasBuffer` check
 
 
 ## 12.4.1 Aug 17, 2023

diff --git a/packages/util/src/u8a/toBuffer.ts b/packages/util/src/u8a/toBuffer.ts
@@ -5,6 +5,8 @@ import type { BufferClass, BufferObject } from '../types.js';
 
 import { xglobal } from '@polkadot/x-global';
 
+import { hasBuffer } from '../has.js';
+
 /**
  * @name u8aToBuffer
  * @summary Creates a Buffer object from a hex string.
@@ -20,5 +22,7 @@ import { xglobal } from '@polkadot/x-global';
  * ```
  */
 export function u8aToBuffer <T = BufferObject> (value?: Uint8Array | null): T {
-  return (xglobal.Buffer as unknown as BufferClass).from(value || []);
+  return hasBuffer
+    ? (xglobal.Buffer as unknown as BufferClass).from(value || [])
+    : new Uint8Array(value || []) as T;
 }