option to decode CBOR's undefined to null #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bleh. We're not going to round-trip this but we shouldn't hit this anyways. Alternatively, we could just return an error. However, that may break things for some users... fixes #43
By default we will raise an error if we encounter the cbor "undefined" byte, because it's a long way from a canonical object if it has one of these bytes in it, and I think we should not be silent about that. If you want to coerce it to null: that's also an option! Diff is a bit larger than one might expect it should be because this turns out to be the first decoding option we've actually passed through all the way to the decoder. Signed-off-by: Eric Myhre <hash@exultant.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #44 (thanks @Stebalien !) plus another commit to add a flag in
cbor.DecodeOptionsto decide whether or not you want "undefined" to be coerced to a null token. The default is to error.