improving token config and create bindingJSON utils

[huf0813]

Hi, i see a lot of insight from @Endrawan and @AFauzulh for better code. Thx guys, i hope there will be more discussions later

[Endrawan]

Thank you for your token improvement @huf0813 . But i still don't understand why you need to create that BindingJSON() method. Maybe you could enlighten me a little?

[Endrawan]

Why not use ShouldBindJSON() ?

[Endrawan]

Is this really necessary? I mean gin already provided ShouldBindJSON() , which exactly works like this

[huf0813]

As you can see on docs. BindJSON() by default will implements two methods, they are ShouldBindWith() and AbortWithError(). If we just implement just ShouldBindJSON() (just implementing ShouldBindWith()) then we will missing something important, that is error handling. That's why i create utils for those.

docs :

1. Binding Model
2. BindJSON()
3. ShouldBindJSON()
4. ShoulBindWIth()

i'll wrap it out, simply like these :

1. ShouldBindWith() + AbortWithError() = BindJSON()
2. ShouldBindWith() + missing error handling = ShouldBindJSON()

[Endrawan]

Okay, but the problem is lies in c.AbortWithError() you called in BindingJSON(). When you called c.AbortWithError(), it will force our server to return a header (in your code its StatusBadRequest). So when we want to change the header to the correct one (for example StatusNotFound), it'll return a warning Headers were already written. Wanted to override status code 400 with 404. Not only that, the c.AbortWithError() will force the response to text/plain as you can see in this issue.

So the point of using ShouldBindJSON() is to handle the error by ourselves not by the gin itself. Just try to change your code

if err := cobs.Binding.BindingJSON(c, &userCobs); err != nil {
	cobs.Res.CustomResponse(c, "Content-Type", "application/json", "error", "failed when binding data", http.StatusNotFound, nil)
	return
}

to this

if err := c.ShouldBindJSON(&userCobs); err != nil {
	cobs.Res.CustomResponse(c, "Content-Type", "application/json", "error", err.Error(), http.StatusNotFound, nil)
	return
}

Then you start your bad request (no body, username with int datatype, etc.) with your postman and see the differences.

[huf0813]

Thx, i need to learn more and will delete that later. Don't feel like bothered by me, ok?

[Endrawan]

Yeah, chill man. It's just a discussion nothing wrong with it

[Endrawan]

It's all good now. Thank you! @huf0813