Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(endpoint): skip tls for kube endpoints #4788

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Conversation

chiptus
Copy link
Contributor

@chiptus chiptus commented Jan 28, 2021

fix #4770

@pull-dog
Copy link

pull-dog bot commented Jan 28, 2021

*Ruff* 🐶 It looks like you are currently using the maximum amount of concurrent test environments 😫

You can upgrade your plan to increase that limit, and our plans are quite cheap.

The following pull requests are using environments from your pool as of writing this comment:

You can also see a live list of all test environments if you wish.

What is this?

Pull Dog is a GitHub app that makes test environments for your pull requests using Docker, from a docker-compose.yml file you specify. It takes 19 seconds to set up (we counted!) and there's a free plan available.

Visit our website to learn more.

Commands
  • @pull-dog up to reprovision or provision the server.
  • @pull-dog down to delete the provisioned server.
Troubleshooting

Need help? Don't hesitate to file an issue in our repository

Configuration

{
  "isLazy": false,
  "dockerComposeYmlFilePaths": [
    "docker-compose.pull-dog.yml"
  ],
  "buildArguments": {
    "PORTAINER_TAG": "pr4788-linux-amd64"
  },
  "label": "test-instance-available",
  "expiry": "1.00:00:00",
  "conversationMode": "singleComment"
}

Trace ID
0HM6DQHPS6OLM:00000003

Copy link
Contributor

@huib-portainer huib-portainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename endpoint for Kubernetes agent endpoint now works.

Copy link

@nzbasic nzbasic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzbasic nzbasic merged commit 739dda1 into develop Feb 17, 2021
@chiptus chiptus deleted the fix4770-broken-kube branch June 21, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing name of kubernetes agent based endpoint breaks the endpoint
4 participants