Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom-templates): switching a template to standalone makes it disappear in swarm mode #4829

Merged
merged 4 commits into from
Feb 22, 2021

Conversation

MaximeBajeux
Copy link
Contributor

Close #4743

@MaximeBajeux MaximeBajeux self-assigned this Feb 7, 2021
@pull-dog
Copy link

pull-dog bot commented Feb 7, 2021

*Ruff* 🐶 The test environment for this pull request has been destroyed 💥 This may have happened explicitly via a command, because the environment expired, or because the pull request was closed.

What is this?

Pull Dog is a GitHub app that makes test environments for your pull requests using Docker, from a docker-compose.yml file you specify. It takes 19 seconds to set up (we counted!) and there's a free plan available.

Visit our website to learn more.

Commands
  • @pull-dog up to reprovision or provision the server.
  • @pull-dog down to delete the provisioned server.
Troubleshooting

Need help? Don't hesitate to file an issue in our repository

Configuration

{
  "isLazy": false,
  "dockerComposeYmlFilePaths": [
    "docker-compose.pull-dog.yml"
  ],
  "buildArguments": {
    "PORTAINER_TAG": "pr4829-linux-amd64"
  },
  "label": "test-instance-available",
  "expiry": "1.00:00:00",
  "conversationMode": "singleComment"
}

Trace ID
No trace ID

@deviantony deviantony removed their request for review February 8, 2021 21:16
@deviantony
Copy link
Member

@pull-dog down

Copy link
Contributor

@huib-portainer huib-portainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom template is correctly shown in the list after it has changed to standalone.

The Deploy button however needs to be disabled in this case:
image

And there is no warning message underneath stating "This template type cannot be deployed on this endpoint.".

Copy link
Contributor

@huib-portainer huib-portainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment is being prevented and a warning message is being shown:

image

Copy link
Contributor

@huib-portainer huib-portainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@jfadelhaye jfadelhaye merged commit c84da11 into develop Feb 22, 2021
vrajashkr pushed a commit to vrajashkr/portainer that referenced this pull request Apr 15, 2021
…isappear in swarm mode (portainer#4829)

* feat(custom-templates): switching a template to standalone makes it disappear in swarm mode

* feat(custom-template): disable deploy button and add an error message

* fix(custom-template): invert variable

* fix(custom-templates): put the warning message below the button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switching a template to standalone makes it disappear in swarm mode
5 participants