Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live updates and sorting for R data explorer #287

Merged
merged 43 commits into from
Apr 3, 2024
Merged

Live updates and sorting for R data explorer #287

merged 43 commits into from
Apr 3, 2024

Commits on Mar 27, 2024

  1. add test for data updates

    @jmcphers
    jmcphers committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ff9dd6c View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. use 'attr' as accessor for attributes

    @jmcphers
    jmcphers committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a439df2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feature/data-explorer… 

    …-updates
    @jmcphers
    jmcphers committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a9453fe View commit details
    Browse the repository at this point in the history

  3. pass an optional variable binding into the data explorer

    @jmcphers
    jmcphers committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b33b214 View commit details
    Browse the repository at this point in the history

  4. listen for prompt signals; emit updates when data changes

    @jmcphers
    jmcphers committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a16fc2c View commit details
    Browse the repository at this point in the history

  5. supply a binding in data explorer test

    @jmcphers
    jmcphers committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3102325 View commit details
    Browse the repository at this point in the history

  6. add a test for schema level updates

    @jmcphers
    jmcphers committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1ed7d1f View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. store column schema in a cache

    @jmcphers
    jmcphers committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    1e659c8 View commit details
    Browse the repository at this point in the history

  2. test for schema vs. data update

    @jmcphers
    jmcphers committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    34d180d View commit details
    Browse the repository at this point in the history

  3. add test for refreshed schema

    @jmcphers
    jmcphers committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    6c2a49f View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into feature/data-explorer… 

    …-updates
    @jmcphers
    jmcphers committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    30ad29d View commit details
    Browse the repository at this point in the history

  5. store current set of sort keys

    @jmcphers
    jmcphers committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    a709a6d View commit details
    Browse the repository at this point in the history

  6. super basic sorting implementation

    @jmcphers
    jmcphers committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    0d434a1 View commit details
    Browse the repository at this point in the history

  7. reset row indices after clearing sorting

    @jmcphers
    jmcphers committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    78817e7 View commit details
    Browse the repository at this point in the history

  8. support for ascending/descending sorting

    @jmcphers
    jmcphers committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    65480b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. add unit test for Vec<bool> conversion

    @jmcphers
    jmcphers committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    09227e4 View commit details
    Browse the repository at this point in the history

  2. add a test to cover multi column sort and descending sort

    @jmcphers
    jmcphers committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    460203b View commit details
    Browse the repository at this point in the history

  3. ensure sorting also affects row labels

    @jmcphers
    jmcphers committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    c8e20a3 View commit details
    Browse the repository at this point in the history

  4. implement and test sorting by matrix column

    @jmcphers
    jmcphers committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    a317f70 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into feature/data-explorer… 

    …-sorting
    @jmcphers
    jmcphers committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    28ce156 View commit details
    Browse the repository at this point in the history

  6. re-sort data after detecting a change

    @jmcphers
    jmcphers committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    03bb91d View commit details
    Browse the repository at this point in the history

  7. close the comm when binding goes away

    @jmcphers
    jmcphers committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    8dd0955 View commit details
    Browse the repository at this point in the history

  8. omit length when computing column type names

    @jmcphers
    jmcphers committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    cee26b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge remote-tracking branch 'origin/main' into feature/data-explorer… 

    …-sorting
    @jmcphers
    jmcphers committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    20dd0f1 View commit details
    Browse the repository at this point in the history

  2. clean up unused imports

    @jmcphers
    jmcphers committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    9eb3bc3 View commit details
    Browse the repository at this point in the history

  3. simplify construction of bool vector

    @jmcphers
    jmcphers committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    7216ee3 View commit details
    Browse the repository at this point in the history

  4. better naming for info about object's name/env

    @jmcphers
    jmcphers committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    76801bc View commit details
    Browse the repository at this point in the history

  5. simplify ternary expression

    @jmcphers
    jmcphers committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    eef64a1 View commit details
    Browse the repository at this point in the history

  6. specify radix sort

    @jmcphers
    jmcphers committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f52d9fa View commit details
    Browse the repository at this point in the history

  7. protect result of update check

    @jmcphers
    jmcphers committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    216221e View commit details
    Browse the repository at this point in the history

  8. use [[ to extract columns from data frames

    @jmcphers
    jmcphers committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    bf01f7a View commit details
    Browse the repository at this point in the history

  9. implement null count summary stats

    @jmcphers
    jmcphers committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8ceb87f View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Extract first test in a reusable function

    @lionel-
    lionel- committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    b00ea6f View commit details
    Browse the repository at this point in the history

  2. Test data explorer with a tibble

    @lionel-
    lionel- committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c0c1e45 View commit details
    Browse the repository at this point in the history

  3. Clean up tibble after test

    @lionel-
    lionel- committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e8bc98a View commit details
    Browse the repository at this point in the history

  4. Update crates/ark/src/data_explorer/r_data_explorer.rs 

    Co-authored-by: Davis Vaughan <davis@rstudio.com>
    @jmcphers @DavisVaughan
    jmcphers and DavisVaughan authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    cf43115 View commit details
    Browse the repository at this point in the history

  5. simplify null/NA counting

    @jmcphers
    jmcphers committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    db0e77c View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into feature/data-explorer… 

    …-sorting
    @jmcphers
    jmcphers committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    007eabd View commit details
    Browse the repository at this point in the history

  7. monitor variable for updates even if provided via View()

    @jmcphers
    jmcphers committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d1d59a4 View commit details
    Browse the repository at this point in the history

  8. simplify object name derivation

    @jmcphers
    jmcphers committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    a7aa213 View commit details
    Browse the repository at this point in the history

  9. convert indices to 1-based at the FFI boundary

    @jmcphers
    jmcphers committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1c05603 View commit details
    Browse the repository at this point in the history

  10. clarify behavior of initial row population

    @jmcphers
    jmcphers committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    609d14a View commit details
    Browse the repository at this point in the history

  11. Update crates/harp/src/object.rs 

    Co-authored-by: Davis Vaughan <davis@rstudio.com>
    @jmcphers @DavisVaughan
    jmcphers and DavisVaughan authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    22ec3bd View commit details
    Browse the repository at this point in the history