Open files via Jupyter instead of LSP #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
approved these changes
May 28, 2024
| for (f in file) { | ||
| # This blocks until a response from the frontend, unlike RStudio which | ||
| # uses a fire-and-forget event. This shouldn't cause any issues. | ||
| .ps.ui.navigateToFile(f) |
There was a problem hiding this comment.
This was probably already the case before, but I guess a different frontend will have to have their own editor hook, or we will eventually make these UI function override-able if you are outside positron
| .ps.Call("ps_editor", file, title) | ||
| for (f in file) { | ||
| # This blocks until a response from the frontend, unlike RStudio which | ||
| # uses a fire-and-forget event. This shouldn't cause any issues. |
There was a problem hiding this comment.
I think I actually prefer blocking in case the user tries to do some immediate follow up code on the opened file (similar to the "save all documents" issue we have about it being non-blocking right now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to:
tokio::RuntimeandClienttoRMain#193As I was working on posit-dev/positron#2999, I initially thought that
Backendshould be the sole owner of aWorldStatestruct which should not be clonable, which meant Backend could no longer be clonable. This PR is a step towards making the LSP the sole owner ofBackendby changing our implementation offile.edit()to make a request via the UI Jupyter comm instead of the LSP. The Jupyter request is blocking, unlike the LSP one, but this is sufficiently fast that it shouldn't matter.Note that I later figured out that a clonable state is a good thing as long it doesn't have any interior mutability. A clone of the worldstate is a snapshot and it allows background workers to work without risking having their data change from under their feet. In any case, making the kernel independent from the LSP is cleaner (see posit-dev/positron#3180), so I've kept this commit.