Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes for mount partition2 on /boot #562

Merged

Conversation

KeerthanaAP
Copy link
Contributor

Fix #533

Verified mulitpath is configured properly in the VM booted with image with p2 mounted as /boot

rhel 9.3:
Disk configuration

[root@rhel9-3 ~]# lsblk
NAME        MAJ:MIN RM  SIZE RO TYPE  MOUNTPOINTS
sda           8:0    0  120G  0 disk  
├─sda1        8:1    0    4M  0 part  
├─sda2        8:2    0  600M  0 part  
├─sda3        8:3    0 10.4G  0 part  
└─mpatha    253:0    0  120G  0 mpath 
  ├─mpatha1 253:1    0    4M  0 part  
  ├─mpatha2 253:2    0  600M  0 part  /boot
  └─mpatha3 253:3    0 10.4G  0 part  /
sdb           8:16   0  120G  0 disk  
├─sdb1        8:17   0    4M  0 part  
├─sdb2        8:18   0  600M  0 part  
├─sdb3        8:19   0 10.4G  0 part  
└─mpatha    253:0    0  120G  0 mpath 
  ├─mpatha1 253:1    0    4M  0 part  
  ├─mpatha2 253:2    0  600M  0 part  /boot
  └─mpatha3 253:3    0 10.4G  0 part  /
sdc           8:32   0  120G  0 disk  
├─sdc1        8:33   0    4M  0 part  
├─sdc2        8:34   0  600M  0 part  
├─sdc3        8:35   0 10.4G  0 part  
└─mpatha    253:0    0  120G  0 mpath 
  ├─mpatha1 253:1    0    4M  0 part  
  ├─mpatha2 253:2    0  600M  0 part  /boot
  └─mpatha3 253:3    0 10.4G  0 part  /
sdd           8:48   0  120G  0 disk  
├─sdd1        8:49   0    4M  0 part  
├─sdd2        8:50   0  600M  0 part  
├─sdd3        8:51   0 10.4G  0 part  
└─mpatha    253:0    0  120G  0 mpath 
  ├─mpatha1 253:1    0    4M  0 part  
  ├─mpatha2 253:2    0  600M  0 part  /boot
  └─mpatha3 253:3    0 10.4G  0 part  /
sde           8:64   0  120G  0 disk  
├─sde1        8:65   0    4M  0 part  
├─sde2        8:66   0  600M  0 part  
├─sde3        8:67   0 10.4G  0 part  
└─mpatha    253:0    0  120G  0 mpath 
  ├─mpatha1 253:1    0    4M  0 part  
  ├─mpatha2 253:2    0  600M  0 part  /boot
  └─mpatha3 253:3    0 10.4G  0 part  /
sdf           8:80   0  120G  0 disk  
├─sdf1        8:81   0    4M  0 part  
├─sdf2        8:82   0  600M  0 part  
├─sdf3        8:83   0 10.4G  0 part  
└─mpatha    253:0    0  120G  0 mpath 
  ├─mpatha1 253:1    0    4M  0 part  
  ├─mpatha2 253:2    0  600M  0 part  /boot
  └─mpatha3 253:3    0 10.4G  0 part  /
sdg           8:96   0  120G  0 disk  
├─sdg1        8:97   0    4M  0 part  
├─sdg2        8:98   0  600M  0 part  
├─sdg3        8:99   0 10.4G  0 part  
└─mpatha    253:0    0  120G  0 mpath 
  ├─mpatha1 253:1    0    4M  0 part  
  ├─mpatha2 253:2    0  600M  0 part  /boot
  └─mpatha3 253:3    0 10.4G  0 part  /
sdh           8:112  0  120G  0 disk  
├─sdh1        8:113  0    4M  0 part  
├─sdh2        8:114  0  600M  0 part  
├─sdh3        8:115  0 10.4G  0 part  
└─mpatha    253:0    0  120G  0 mpath 
  ├─mpatha1 253:1    0    4M  0 part  
  ├─mpatha2 253:2    0  600M  0 part  /boot
  └─mpatha3 253:3    0 10.4G  0 part  /
sr0          11:0    1  506K  0 rom   

Multipath is not configured when the instance booted with the image without p2 mounted as /boot
rhel 9.3:
Disk configuration

[root@rhel93-wm ~]# lsblk
NAME   MAJ:MIN RM   SIZE RO TYPE MOUNTPOINTS
sda      8:0    0   120G  0 disk 
├─sda1   8:1    0     4M  0 part 
├─sda2   8:2    0   600M  0 part 
└─sda3   8:3    0 119.4G  0 part 
sdb      8:16   0   120G  0 disk 
├─sdb1   8:17   0     4M  0 part 
├─sdb2   8:18   0   600M  0 part 
└─sdb3   8:19   0 119.4G  0 part /
sdc      8:32   0   120G  0 disk 
├─sdc1   8:33   0     4M  0 part 
├─sdc2   8:34   0   600M  0 part 
└─sdc3   8:35   0 119.4G  0 part 
sdd      8:48   0   120G  0 disk 
├─sdd1   8:49   0     4M  0 part 
├─sdd2   8:50   0   600M  0 part 
└─sdd3   8:51   0 119.4G  0 part 
sde      8:64   0   120G  0 disk 
├─sde1   8:65   0     4M  0 part 
├─sde2   8:66   0   600M  0 part 
└─sde3   8:67   0 119.4G  0 part 
sdf      8:80   0   120G  0 disk 
├─sdf1   8:81   0     4M  0 part 
├─sdf2   8:82   0   600M  0 part /boot
└─sdf3   8:83   0 119.4G  0 part 
sdg      8:96   0   120G  0 disk 
├─sdg1   8:97   0     4M  0 part 
├─sdg2   8:98   0   600M  0 part 
└─sdg3   8:99   0 119.4G  0 part 
sdh      8:112  0   120G  0 disk 
├─sdh1   8:113  0     4M  0 part 
├─sdh2   8:114  0   600M  0 part 
└─sdh3   8:115  0 119.4G  0 part 
sr0     11:0    1   506K  0 rom  

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2024
@mkumatag
Copy link
Member

/cc @sudeeshjohn

@ppc64le-cloud-bot ppc64le-cloud-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2024
@KeerthanaAP KeerthanaAP force-pushed the qcow2ova_multipath branch 2 times, most recently from a96bf09 to ed2197c Compare February 27, 2024 07:45
@mkumatag
Copy link
Member

/cc @kishen-v

@KeerthanaAP KeerthanaAP force-pushed the qcow2ova_multipath branch 2 times, most recently from 2b3b6ba to 63f894f Compare February 28, 2024 16:26
@kishen-v
Copy link
Contributor

kishen-v commented Feb 29, 2024

@KeerthanaAP, please resolve the comments that have been addressed.

@KeerthanaAP
Copy link
Contributor Author

KeerthanaAP commented Feb 29, 2024

@kishen-v Resolved all the comments which are addressed. Could you PTAL!
Thanks!

cmd/image/qcow2ova/prep/loop.go Outdated Show resolved Hide resolved
cmd/image/qcow2ova/prep/prepare.go Outdated Show resolved Hide resolved
@KeerthanaAP KeerthanaAP force-pushed the qcow2ova_multipath branch 2 times, most recently from eeececc to 98b9809 Compare March 13, 2024 03:34
@suhailos
Copy link

@sudeeshjohn @kishen-v @bkhadars need your action on this pls.

@kishen-v
Copy link
Contributor

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2024
@mkumatag
Copy link
Member

@sudeeshjohn ptal and remove the hold whenever you are comfortable!

/approve
/hold

@ppc64le-cloud-bot ppc64le-cloud-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2024
Copy link
Contributor

@sudeeshjohn sudeeshjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KeerthanaAP, mkumatag, sudeeshjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sudeeshjohn
Copy link
Contributor

/unhold

@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit bf8b98e into ppc64le-cloud:main Mar 26, 2024
4 of 5 checks passed
@KeerthanaAP KeerthanaAP deleted the qcow2ova_multipath branch April 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qcow2ova does not mount /boot
6 participants